Add install size badge to readme #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @19majkel94! ✋Thank you for your contribution! I don't know if this badge is really that important, but... if you say so, then let's merge it 😄Can you add it to CLI Readme as well (in the same PR)? Also, could you please rebase your PR to latest master? I fixed Travis configuration for building PRs from forks. Now the build should be green. Thanks! |
pkosiec
requested changes
Oct 8, 2018
README.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| # Mongo Seeding | |||
|
|
|||
| [](https://badge.fury.io/gh/pkosiec%2Fmongo-seeding) [](https://travis-ci.org/pkosiec/mongo-seeding) [](https://lbesson.mit-license.org/) | |||
| [](https://badge.fury.io/gh/pkosiec%2Fmongo-seeding) [](https://travis-ci.org/pkosiec/mongo-seeding) [](https://lbesson.mit-license.org/) [](https://packagephobia.now.sh/result?p=mongo-seeding) | |||
There was a problem hiding this comment.
This badge should be moved to core/README.md, as it is related to only JS library.
cli/README.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| # Mongo Seeding CLI | |||
|
|
|||
| [](https://npmjs.org/package/mongo-seeding-cli) []() []() | |||
| [](https://npmjs.org/package/mongo-seeding-cli) []() []() [](https://packagephobia.now.sh/result?p=mongo-seeding) | |||
There was a problem hiding this comment.
CLI has a different package name: mongo-seeding-cli
pkosiec
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very important badge that will inform library consumers about the install size of the npm package.